-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename v to my_van #1327
fix: rename v to my_van #1327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @KamilPawel)
game/static/game/js/blocklyCustomBlocks.js, line 434 at r1 (raw file):
Blockly.Python['cow_crossing'] = function(block) { return ['v.cow_crossing()', Blockly.Python.ORDER_NONE];
Not sure if used, but we can rename this too 🙂
game/views/level_solutions.py, line 283 at r1 (raw file):
"python_default": python_default, "blockly_default": blockly_default, "1": '<xml xmlns="http://www.w3.org/1999/xhtml"><block type="start" deletable="false" x="230" y="30"><next><block type="turn_left"></block></next></block></xml>',
lol 😆
game/views/scoreboard_csv.py, line 47 at r1 (raw file):
rows.append(row) writer = csmy_van.writer(response)
Search&Replace fail 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @KamilPawel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @razvan-pro)
game/static/game/js/blocklyCustomBlocks.js, line 434 at r1 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
Not sure if used, but we can rename this too 🙂
Done.
game/views/scoreboard_csv.py, line 47 at r1 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
Search&Replace fail 😄
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KamilPawel)
game/static/game/js/game.js, line 142 at r4 (raw file):
let code = ocargo.pythonControl.getCode() console.log(code)
Console log 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KamilPawel)
game/static/game/js/game.js, line 153 at r5 (raw file):
ocargo.Drawing.startPopup( gettext('Oh dear!'), "You can only import 'van' from 'Van'",
'Van' from 'van' 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @faucomte97 and @razvan-pro)
game/static/game/js/game.js, line 153 at r5 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
'Van' from 'van' 🙂
Done.
Codecov Report
@@ Coverage Diff @@
## master #1327 +/- ##
=======================================
Coverage 91.69% 91.69%
=======================================
Files 98 98
Lines 5265 5265
=======================================
Hits 4828 4828
Misses 437 437
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)
Description
How Has This Been Tested?
Screenshots (if appropriate):
Checklist:
This change is