feat: Update styles of the game pt. 1 #1356
Conversation
There was a problem hiding this comment.
Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97)
game/templates/game/base.html line 14 at r1 (raw file):
{% block css %} {{block.super}}
Missing indentation 😞
game/templates/game/level_selection.html line 79 at r1 (raw file):
{% for episode in blocklyEpisodes %} <div class="panel"> {% if episode.id == 5 or episode.id == 6 %}
Minor, probably a nicer way of doing this would be to store these classes/difficulties in the DB (or model property?), then we could just have something like: <div class="panel-header bg--{{episode.difficulty}}" id="episode-{{episode.id}}"> 🙂
There was a problem hiding this comment.
Reviewable status: 15 of 20 files reviewed, 1 unresolved discussion (waiting on @faucomte97 and @razvan-pro)
game/templates/game/base.html line 14 at r1 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
Missing indentation 😞
Done.
game/templates/game/level_selection.html line 79 at r1 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
Minor, probably a nicer way of doing this would be to store these classes/difficulties in the DB (or model property?), then we could just have something like:
<div class="panel-header bg--{{episode.difficulty}}" id="episode-{{episode.id}}">🙂
Done :)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, 3 of 4 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
Codecov Report
@@ Coverage Diff @@
## master #1356 +/- ##
=======================================
Coverage 92.16% 92.17%
=======================================
Files 99 99
Lines 5311 5317 +6
=======================================
+ Hits 4895 4901 +6
Misses 416 416
|
This change is