Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include students from other classes in level moderation for admin teachers #1358

Merged
merged 4 commits into from
Aug 1, 2022

Conversation

razvan-pro
Copy link
Collaborator

@razvan-pro razvan-pro commented Jul 28, 2022

This change is Reviewable

@razvan-pro razvan-pro self-assigned this Jul 28, 2022
Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @razvan-pro)

a discussion (no related file):
Admin teachers missing the permission to play levels owned by other teachers' students


Copy link
Collaborator Author

@razvan-pro razvan-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)

a discussion (no related file):

Previously, faucomte97 (Florian Aucomte) wrote…

Admin teachers missing the permission to play levels owned by other teachers' students

To be done in the other task 🙂


Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @razvan-pro)

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #1358 (8aad00a) into master (d6b55f2) will increase coverage by 0.10%.
The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1358      +/-   ##
==========================================
+ Coverage   92.17%   92.27%   +0.10%     
==========================================
  Files          99       99              
  Lines        5317     5336      +19     
==========================================
+ Hits         4901     4924      +23     
+ Misses        416      412       -4     
Impacted Files Coverage Δ
game/permissions.py 77.35% <75.00%> (+0.35%) ⬆️
game/forms.py 100.00% <100.00%> (ø)
game/views/level_moderation.py 91.66% <100.00%> (+2.19%) ⬆️
game/random_road.py 91.00% <0.00%> (-0.36%) ⬇️
game/views/level_editor.py 70.46% <0.00%> (+3.10%) ⬆️

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @razvan-pro)

@faucomte97 faucomte97 merged commit 37021c9 into master Aug 1, 2022
@faucomte97 faucomte97 deleted the admin-level-moderation branch August 1, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants