Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Shared levels table #1364

Merged
merged 9 commits into from
Aug 11, 2022
Merged

feat: Shared levels table #1364

merged 9 commits into from
Aug 11, 2022

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Aug 10, 2022

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Aug 10, 2022
@faucomte97 faucomte97 marked this pull request as ready for review August 10, 2022 17:06
Copy link

@mg931 mg931 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #1364 (1c8af8c) into master (11e1773) will increase coverage by 0.02%.
The diff coverage is 93.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1364      +/-   ##
==========================================
+ Coverage   92.29%   92.31%   +0.02%     
==========================================
  Files          99       99              
  Lines        5348     5390      +42     
==========================================
+ Hits         4936     4976      +40     
- Misses        412      414       +2     
Impacted Files Coverage Δ
game/views/scoreboard.py 91.13% <90.69%> (+0.27%) ⬆️
game/views/scoreboard_csv.py 100.00% <100.00%> (ø)

@faucomte97 faucomte97 merged commit b66673f into master Aug 11, 2022
@faucomte97 faucomte97 deleted the shared_levels_table branch August 11, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants