fix: Resolve scoreboard and button issues #1369
Conversation
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97)
Pipfile line 16 at r2 (raw file):
pytest = "==7.*" pytest-xdist = "*" pytest-order = "*"
Is that Mykhaylo change? 🤔
game/templates/game/scoreboard.html line 259 at r2 (raw file):
</table> {% else %} No data.
No data without any <></> tags?
There was a problem hiding this comment.
Reviewable status: 6 of 7 files reviewed, 2 unresolved discussions (waiting on @KamilPawel)
Pipfile line 16 at r2 (raw file):
Previously, KamilPawel wrote…
Is that Mykhaylo change? 🤔
He seemed to have added it to the ci.yml yeah, so I thought I'd move it and add it to the Pipfile instead along with the xdist one
game/templates/game/scoreboard.html line 259 at r2 (raw file):
Previously, KamilPawel wrote…
No data without any <></> tags?
Good catch 😛
There was a problem hiding this comment.
Reviewable status: 6 of 7 files reviewed, all discussions resolved (waiting on @KamilPawel)
There was a problem hiding this comment.
Reviewable status: 6 of 7 files reviewed, all discussions resolved (waiting on @KamilPawel)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
Codecov Report
@@ Coverage Diff @@
## master #1369 +/- ##
==========================================
- Coverage 91.77% 91.75% -0.02%
==========================================
Files 98 98
Lines 5421 5421
==========================================
- Hits 4975 4974 -1
- Misses 446 447 +1
|
This change is