Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Level access control logic #1379

Merged
merged 4 commits into from
Nov 15, 2022
Merged

feat: Level access control logic #1379

merged 4 commits into from
Nov 15, 2022

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Nov 14, 2022

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Nov 14, 2022
Copy link
Contributor

@KamilPawel KamilPawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #1379 (8f41cd1) into master (3f22487) will decrease coverage by 0.07%.
The diff coverage is 95.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1379      +/-   ##
==========================================
- Coverage   91.80%   91.72%   -0.08%     
==========================================
  Files          98       99       +1     
  Lines        5457     5477      +20     
==========================================
+ Hits         5010     5024      +14     
- Misses        447      453       +6     
Impacted Files Coverage Δ
example_project/rapid_router_test_settings.py 100.00% <ø> (ø)
example_project/settings.py 0.00% <ø> (ø)
game/urls.py 100.00% <ø> (ø)
game/views/level.py 71.14% <90.90%> (+1.35%) ⬆️
game/admin.py 100.00% <100.00%> (ø)
game/migrations/0076_level_locked_for_class.py 100.00% <100.00%> (ø)
game/models.py 95.00% <100.00%> (+0.04%) ⬆️
game/permissions.py 72.72% <100.00%> (-5.06%) ⬇️
game/views/level_selection.py 92.24% <100.00%> (+0.27%) ⬆️

Copy link
Contributor

@KamilPawel KamilPawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@faucomte97 faucomte97 merged commit 746da41 into master Nov 15, 2022
@faucomte97 faucomte97 deleted the levels_partial_template branch November 15, 2022 12:37
@faucomte97 faucomte97 mentioned this pull request Nov 15, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants