feat: prev next buttons #1383
feat: prev next buttons #1383
Conversation
There was a problem hiding this comment.
Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @KamilPawel)
game/migrations/0077_alter_level_next_level.py line 19 at r1 (raw file):
Level_Object_Wrapper.filter(name=level.name).update( next_level=next_level_update )
can you add some code which is the reverse of this please, just like we have in migration 0075 for example
Code quote:
def add_next_level_to_last_levels(apps, schema_editor):
Level = apps.get_model("game", "Level")
db_alias = schema_editor.connection.alias
Level_Object_Wrapper = Level.objects.using(db_alias)
levels = Level_Object_Wrapper.filter(next_level=None).exclude(name="109")
for level in levels:
next_level_update = Level_Object_Wrapper.get(
name=(str(int(level.name) + 1))
)
Level_Object_Wrapper.filter(name=level.name).update(
next_level=next_level_update
)game/static/game/css/game_screen.css line 291 at r1 (raw file):
padding: 0px; }
Extra line
game/static/game/js/drawing.js line 1057 at r1 (raw file):
// buttons are passed as html string.. // hence this terribleness if (Array.isArray(buttons)) {
Can we have more comments for this function please
game/static/game/js/game.js line 428 at r1 (raw file):
if (pythonSliderPosition < 30) { pythonSliderPosition = 30 codeWindowHeight = 30
What is this for?
Code quote:
if (pythonSliderPosition < 30) {
pythonSliderPosition = 30
codeWindowHeight = 30game/views/level.py line 68 at r1 (raw file):
prev_level = prev_level.prev_level.all()[0] except: print("Fegcrjhsvunicoa khudsFAUL")
Kamil come on 😛
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @KamilPawel)
game/end_to_end_tests/base_game_test.py line 82 at r3 (raw file):
path = reverse("play_default_level", kwargs={"levelName": str(level_name)}) self._go_to_path(path) if close_popup:
Do we need this in the end?
There was a problem hiding this comment.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @faucomte97)
game/end_to_end_tests/base_game_test.py line 82 at r3 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Do we need this in the end?
Nope
game/migrations/0077_alter_level_next_level.py line 19 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
can you add some code which is the reverse of this please, just like we have in migration 0075 for example
Done.
game/static/game/css/game_screen.css line 291 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Extra line
Done.
game/static/game/js/drawing.js line 1057 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Can we have more comments for this function please
Done.
game/static/game/js/game.js line 428 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
What is this for?
The slider in python level, limiting it so you cannot go too high up
game/views/level.py line 68 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Kamil come on 😛
That looks like 2am code 😂
There was a problem hiding this comment.
Reviewable status: 9 of 14 files reviewed, 6 unresolved discussions (waiting on @faucomte97)
There was a problem hiding this comment.
Reviewed 5 of 5 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KamilPawel)
game/end_to_end_tests/base_game_test.py line 82 at r3 (raw file):
Previously, KamilPawel wrote…
Nope
Then remove it from the arguments as well 😉
game/migrations/0077_alter_level_next_level.py line 19 at r1 (raw file):
Previously, KamilPawel wrote…
Done.
Ok but you need to call it 😝
There was a problem hiding this comment.
Reviewable status: 12 of 14 files reviewed, 1 unresolved discussion (waiting on @faucomte97)
game/end_to_end_tests/base_game_test.py line 82 at r3 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Then remove it from the arguments as well 😉
Done.
game/migrations/0077_alter_level_next_level.py line 19 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Ok but you need to call it 😝
😂
There was a problem hiding this comment.
Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)
Codecov Report
@@ Coverage Diff @@
## master #1383 +/- ##
==========================================
- Coverage 91.72% 91.57% -0.16%
==========================================
Files 99 100 +1
Lines 5477 5506 +29
==========================================
+ Hits 5024 5042 +18
- Misses 453 464 +11
|
Description
How Has This Been Tested?
Checklist:
This change is