Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove algorithm score for early levels but keep maximum score 20 coins #1414

Conversation

sebp999
Copy link
Contributor

@sebp999 sebp999 commented Feb 1, 2023

Description

Fixes #1286. Adds a field disable_algorithm_scoring and sets it to True for Levels 1-12. If the algorithm scoring is disabled for a level, no coins or score will appear in the popup for algorithm on a successful try. Because users could score 20 points before the change, the maximum route score for levels 1-12 is now 20, not 10.

How Has This Been Tested?

By adapting and running Selenium tests

Checklist:

  • [ x ] My change requires a change to the documentation.
  • [ x ] I have updated the documentation accordingly.
  • [ ✅ ] I have linked this PR to a ZenHub Issue.

This change is Reviewable

@sebp999 sebp999 changed the title 1286 remove algo score 20 coins early levels feat: Remove algorithm score for early levels but keep maximum score 20 coins Feb 1, 2023
@sebp999 sebp999 requested review from faucomte97 and KamilPawel and removed request for faucomte97 February 2, 2023 08:35
Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #1414 (a7f41f5) into master (d06d4eb) will decrease coverage by 0.01%.
The diff coverage is 97.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1414      +/-   ##
==========================================
- Coverage   91.55%   91.55%   -0.01%     
==========================================
  Files         102      104       +2     
  Lines        5533     5556      +23     
==========================================
+ Hits         5066     5087      +21     
- Misses        467      469       +2     
Impacted Files Coverage Δ
game/views/scoreboard.py 90.94% <88.88%> (-0.20%) ⬇️
game/end_to_end_tests/base_game_test.py 94.07% <100.00%> (+0.07%) ⬆️
game/end_to_end_tests/test_level_failures.py 100.00% <100.00%> (ø)
game/end_to_end_tests/test_play_through.py 100.00% <100.00%> (ø)
...e/migrations/0080_level_disable_algorithm_score.py 100.00% <100.00%> (ø)
...e/migrations/0081_first_12_levels_no_algo_score.py 100.00% <100.00%> (ø)
game/models.py 95.16% <100.00%> (+0.03%) ⬆️
game/random_road.py 90.90% <0.00%> (-0.37%) ⬇️

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)

@faucomte97 faucomte97 merged commit 5cc45bd into ocadotechnology:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Algorithm score from lower levels in Rapid Router
2 participants