-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove algorithm score for early levels but keep maximum score 20 coins #1414
feat: Remove algorithm score for early levels but keep maximum score 20 coins #1414
Conversation
…coring for levels 1-12
…d is 20 not 10, so that it isn't unfair
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)
Codecov Report
@@ Coverage Diff @@
## master #1414 +/- ##
==========================================
- Coverage 91.55% 91.55% -0.01%
==========================================
Files 102 104 +2
Lines 5533 5556 +23
==========================================
+ Hits 5066 5087 +21
- Misses 467 469 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)
Description
Fixes #1286. Adds a field
disable_algorithm_scoring
and sets it toTrue
for Levels 1-12. If the algorithm scoring is disabled for a level, no coins or score will appear in the popup for algorithm on a successful try. Because users could score 20 points before the change, the maximum route score for levels 1-12 is now 20, not 10.How Has This Been Tested?
By adapting and running Selenium tests
Checklist:
This change is