Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Scenery bug #1418

Merged
merged 3 commits into from
Feb 16, 2023
Merged

fix: Scenery bug #1418

merged 3 commits into from
Feb 16, 2023

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Feb 10, 2023

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Feb 10, 2023
@faucomte97 faucomte97 enabled auto-merge (squash) February 10, 2023 16:19
@faucomte97 faucomte97 disabled auto-merge February 15, 2023 15:12
Copy link
Contributor

@KamilPawel KamilPawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #1418 (c7fd020) into master (385a884) will increase coverage by 0.13%.
The diff coverage is 100.00%.

❗ Current head c7fd020 differs from pull request most recent head e12977f. Consider uploading reports for the commit e12977f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1418      +/-   ##
==========================================
+ Coverage   91.44%   91.57%   +0.13%     
==========================================
  Files         104      104              
  Lines        5564     5555       -9     
==========================================
- Hits         5088     5087       -1     
+ Misses        476      468       -8     
Impacted Files Coverage Δ
game/level_management.py 89.77% <100.00%> (-0.12%) ⬇️
game/views/level_editor.py 72.46% <100.00%> (ø)
game/random_road.py 91.27% <0.00%> (+0.72%) ⬆️
...e/migrations/0081_first_12_levels_no_algo_score.py 100.00% <0.00%> (+33.33%) ⬆️

@faucomte97 faucomte97 merged commit 88c7ad3 into master Feb 16, 2023
@faucomte97 faucomte97 deleted the scenery_bug branch February 16, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants