Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix migration 81 #1419

Merged
merged 3 commits into from
Feb 15, 2023
Merged

fix: Fix migration 81 #1419

merged 3 commits into from
Feb 15, 2023

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Feb 15, 2023

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Feb 15, 2023
Copy link
Contributor

@KamilPawel KamilPawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @faucomte97)


game/migrations/0081_first_12_levels_no_algo_score.py line 12 at r2 (raw file):

        for i in range(1, 13):
            level = official_levels.get(name=str(i))
            level.disable_algorithm_score = True

great

Copy link
Contributor

@KamilPawel KamilPawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)


game/migrations/0081_first_12_levels_no_algo_score.py line 11 at r1 (raw file):

        official_levels = Level.objects.filter(default=True)
        for i in range(1, 13):
            l = official_levels.get(name=str(i))

Good

Copy link
Contributor

@KamilPawel KamilPawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)

Copy link
Contributor

@KamilPawel KamilPawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@faucomte97 faucomte97 enabled auto-merge (squash) February 15, 2023 15:15
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #1419 (d9f3504) into master (d06d4eb) will decrease coverage by 0.10%.
The diff coverage is 86.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1419      +/-   ##
==========================================
- Coverage   91.55%   91.46%   -0.10%     
==========================================
  Files         102      104       +2     
  Lines        5533     5564      +31     
==========================================
+ Hits         5066     5089      +23     
- Misses        467      475       +8     
Impacted Files Coverage Δ
...e/migrations/0081_first_12_levels_no_algo_score.py 66.66% <66.66%> (ø)
game/views/scoreboard.py 90.94% <88.88%> (-0.20%) ⬇️
game/__init__.py 100.00% <100.00%> (ø)
game/end_to_end_tests/base_game_test.py 94.07% <100.00%> (+0.07%) ⬆️
game/end_to_end_tests/test_level_failures.py 100.00% <100.00%> (ø)
game/end_to_end_tests/test_play_through.py 100.00% <100.00%> (ø)
...e/migrations/0080_level_disable_algorithm_score.py 100.00% <100.00%> (ø)
game/models.py 95.16% <100.00%> (+0.03%) ⬆️
game/random_road.py 90.90% <0.00%> (-0.37%) ⬇️

@faucomte97 faucomte97 merged commit ddf8d17 into master Feb 15, 2023
@faucomte97 faucomte97 deleted the fix_migration_81 branch February 15, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants