-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix migration 81 #1419
fix: Fix migration 81 #1419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @faucomte97)
game/migrations/0081_first_12_levels_no_algo_score.py
line 12 at r2 (raw file):
for i in range(1, 13): level = official_levels.get(name=str(i)) level.disable_algorithm_score = True
great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)
game/migrations/0081_first_12_levels_no_algo_score.py
line 11 at r1 (raw file):
official_levels = Level.objects.filter(default=True) for i in range(1, 13): l = official_levels.get(name=str(i))
Good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
Codecov Report
@@ Coverage Diff @@
## master #1419 +/- ##
==========================================
- Coverage 91.55% 91.46% -0.10%
==========================================
Files 102 104 +2
Lines 5533 5564 +31
==========================================
+ Hits 5066 5089 +23
- Misses 467 475 +8
|
This change is