Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1477: use correct student login URL in level editor JS #1514

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

benbacardi
Copy link
Contributor

@benbacardi benbacardi commented Nov 3, 2023

Description

Use the correct student login URL in the level editor popup.

How Has This Been Tested?

Tested locally in the browser.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have linked this PR to a ZenHub Issue.

This change is Reviewable

@benbacardi benbacardi changed the title fix: ocadotechnology#1477: use correct student login URL in level editor JS fix: #1477: use correct student login URL in level editor JS Nov 3, 2023
@faucomte97 faucomte97 marked this pull request as ready for review December 20, 2023 22:03
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c26016) 91.79% compared to head (2164b26) 91.69%.
Report is 2 commits behind head on master.

❗ Current head 2164b26 differs from pull request most recent head b92d19d. Consider uploading reports for the commit b92d19d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1514      +/-   ##
==========================================
- Coverage   91.79%   91.69%   -0.11%     
==========================================
  Files         110      110              
  Lines        5875     5864      -11     
==========================================
- Hits         5393     5377      -16     
- Misses        482      487       +5     

see 6 files with indirect coverage changes

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @benbacardi)

@faucomte97 faucomte97 merged commit 469e1c4 into ocadotechnology:master Dec 20, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants