Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dee from level 116 popup #1518

Closed
faucomte97 opened this issue Nov 6, 2023 · 2 comments
Closed

Remove Dee from level 116 popup #1518

faucomte97 opened this issue Nov 6, 2023 · 2 comments
Assignees
Labels
bug good first issue Good issue for first time contributor volunteers Tasks that can be picked up by anyone

Comments

@faucomte97
Copy link
Contributor

faucomte97 commented Nov 6, 2023

Describe the bug
A while back we updated the look and feel of the Rapid Router levels & episodes by making the Python levels (level 80 and above) more grown-up. This included a change in colour scheme and removing the Dee image from the intro popups in the levels.
We recently added levels 110-122 and level 116's intro popup has the Dee image in it. This is because it is the only level above level 80 which is a Blockly-only level.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to level 116.
  2. Notice that Dee is in the intro popup.

Expected behaviour
Dee should not be in the popup.
As of now, I imagine the logic works as follows: if the level is a Blockly level => show Dee, otherwise (if level is Blockly w/ Python or just Python) => hide Dee.
The logic should then probably be amended so that any level above level 80 hides Dee in their intro popup.

Screenshots
image

@faucomte97 faucomte97 added bug good first issue Good issue for first time contributor volunteers Tasks that can be picked up by anyone labels Nov 6, 2023
@AbdelrahmanDeghedy
Copy link
Contributor

AbdelrahmanDeghedy commented Dec 26, 2023

Do levels above 80 should hide all characters or just Dee? So is changing the logic to hide characters above level 80 correct? If it's correct, I can work on it.

@faucomte97
Copy link
Contributor Author

Hi @AbdelrahmanDeghedy, at the moment yes, all levels above 80 should hide all characters. Changing the logic to hide all characters above level 80 should work fine 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Good issue for first time contributor volunteers Tasks that can be picked up by anyone
Projects
None yet
Development

No branches or pull requests

2 participants