Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cows are always visible and horn horns on the right square #1545

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Nov 28, 2023

This PR:

  • Makes it so that cows are always visible ie from the moment the level is loaded.
  • Fixes the distance at which the cow is detected, so that the horn needs to be sounded just before the van crashes into it instead of one square before.

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Nov 28, 2023
Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@faucomte97 faucomte97 enabled auto-merge (squash) November 30, 2023 16:40
@faucomte97 faucomte97 merged commit d44adc7 into master Nov 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants