Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename episodes and levels #1581

Merged
merged 3 commits into from
Feb 15, 2024
Merged

fix: rename episodes and levels #1581

merged 3 commits into from
Feb 15, 2024

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Feb 13, 2024

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 11 unresolved discussions (waiting on @SKairinos)


game/messages.py line 1229 at r1 (raw file):

def title_level52():
    return "A bit more Tricky"

lowercase tricky please


game/messages.py line 1818 at r1 (raw file):

def title_level84():
    return "Repeat and watch"

Maybe "Repeat" should be bold


game/messages.py line 1835 at r1 (raw file):

def title_level85():
    return "Looks easy but use repeat until and see what happens?"

"repeat until" should be bold


game/messages.py line 1853 at r1 (raw file):

def title_level86():
    return "See what the if blocks looks like in Python"

"if" should be bold


game/messages.py line 1869 at r1 (raw file):

def title_level87():
    return "Don't forget to use else if"

"else if" should be bold


game/messages.py line 2477 at r1 (raw file):

    hint_level117,
) = (
    lambda: "Wiggle while you work",

Should "while" be bold?


game/messages.py line 2890 at r1 (raw file):

        11: "Python",
        12: "Counted Loops Using While",
        13: "Indeterminate While loops - coming soon",

Shouldn't "loops" be capitalised if we're following title case?


game/migrations/0087_rename_episodes.py line 0 at r1 (raw file):

  1. Merge master into this branch
  2. Update this migration to be migration 0088 (0087 already exists)

game/migrations/0087_rename_episodes.py line 0 at r1 (raw file):
Run Black on this file


game/migrations/0087_rename_episodes.py line 14 at r1 (raw file):

    
    update_episode_name(pk=12, name="Counted Loops Using While")
    update_episode_name(pk=13, name="Indeterminate While loops - coming soon")

Shouldn't "loops" be capitalised if we're following title case?


game/migrations/0087_rename_episodes.py line 29 at r1 (raw file):

class Migration(migrations.Migration):
    dependencies = [("game", "0086_loop_levels")]

Update this to the name of migration 0087

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1.
Reviewable status: all files reviewed, 11 unresolved discussions (waiting on @SKairinos)

Copy link
Contributor Author

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 11 unresolved discussions (waiting on @faucomte97)


game/messages.py line 1229 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

lowercase tricky please

Done.


game/messages.py line 1818 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Maybe "Repeat" should be bold

Done.


game/messages.py line 1835 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

"repeat until" should be bold

Done.


game/messages.py line 1853 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

"if" should be bold

Done.


game/messages.py line 1869 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

"else if" should be bold

Done.


game/messages.py line 2477 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Should "while" be bold?

Done.


game/messages.py line 2890 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Shouldn't "loops" be capitalised if we're following title case?

Done.


game/migrations/0087_rename_episodes.py line 14 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Shouldn't "loops" be capitalised if we're following title case?

Done.


game/migrations/0087_rename_episodes.py line 29 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Update this to the name of migration 0087

Done.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

Copy link
Contributor Author

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)


game/migrations/0087_rename_episodes.py line at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…
  1. Merge master into this branch
  2. Update this migration to be migration 0088 (0087 already exists)

Done.


game/migrations/0087_rename_episodes.py line at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Run Black on this file

Done.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@faucomte97 faucomte97 merged commit c9f01a7 into master Feb 15, 2024
6 of 7 checks passed
@faucomte97 faucomte97 deleted the rename branch February 15, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants