fix: forbid cows from origin and house spaces

[evemartin]

This change is 

[faucomte97]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @evemartin)

---

game/end_to_end_tests/test_level_editor.py line 97 at r1 (raw file):

        allowed_space = self.selenium.find_elements(By.CSS_SELECTOR, "rect[fill='#87e34d']")
        assert len(allowed_space) == 0
        

Remove extra whitespaces

---

game/static/game/js/level_editor.js line 1697 at r1 (raw file):

        function isValidPlacement(controlledCoord){
            var controlledNode = ocargo.Node.findNodeByCoordinate(controlledCoord, nodes);
            if (!controlledNode || isOriginCoordinate(controlledCoord) || isHouseCoordinate(controlledCoord))

Check with Laura but it seems there is no really clear feedback if you try to put a cow on a start block or a house block. The cow stays there, the only visible difference is that it doesn't snap to the road. Not sure what the feedback should be though, maybe Laura would have a preference.

[evemartin]

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @faucomte97)

---

game/end_to_end_tests/test_level_editor.py line 97 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Remove extra whitespaces

Fixed!

---

game/static/game/js/level_editor.js line 1697 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

Check with Laura but it seems there is no really clear feedback if you try to put a cow on a start block or a house block. The cow stays there, the only visible difference is that it doesn't snap to the road. Not sure what the feedback should be though, maybe Laura would have a preference.

I've checked with Laura - since no other object on the map (like traffic lights for instance) has feedback besides red/green highlighting for invalid/valid spaces, she suggested leaving it this way for now and considering how to give more user feedback in the future!

[faucomte97]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @evemartin)

[faucomte97]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @evemartin)