Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid cow squares remain highlighted #1643

Open
evemartin opened this issue Jun 6, 2024 · 5 comments · Fixed by #1752
Open

invalid cow squares remain highlighted #1643

evemartin opened this issue Jun 6, 2024 · 5 comments · Fixed by #1752
Assignees
Labels
bug volunteers Tasks that can be picked up by anyone

Comments

@evemartin
Copy link
Contributor

evemartin commented Jun 6, 2024

Describe the bug
Sometimes after a cow is placed on an invalid square, the square remains highlighted when the user moves their mouse away.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to Level Editor
  2. Add a cow to the grid and drag it to be right on the leftmost edge of an invalid square (see screenshot)
  3. Drop the cow in that position and move your mouse away to the left, i.e. do not move your mouse over the square
  4. Notice that the square stays highlighted white when it should not be highlighted at all
  5. Bonus: when you move your mouse over and off the highlighted square, only then does it unhighlight

Expected behaviour
The cow square should unhighlight as soon as the cow is dropped

Screenshots
Screenshot from 2024-06-06 14-21-44

@lauracumming lauracumming added the volunteers Tasks that can be picked up by anyone label Jun 25, 2024
@faucomte97 faucomte97 added bug in2science volunteers Tasks that can be picked up by anyone and removed volunteers Tasks that can be picked up by anyone in2science labels Jul 9, 2024
@RaihanRasheedApurbo
Copy link
Contributor

FYI: I am working on a fix on this.

@SKairinos
Copy link
Contributor

@RaihanRasheedApurbo , we're not sure if you're still active on this we'll change the status of this task to "To Do". If you're still working on this, please comment and we'll put it back in "In Progress".
Thank you for all your contributions! 🎉

@RaihanRasheedApurbo
Copy link
Contributor

@SKairinos @faucomte97 #1752

@SKairinos SKairinos linked a pull request Dec 9, 2024 that will close this issue
3 tasks
@SKairinos
Copy link
Contributor

SKairinos commented Dec 9, 2024

Ty @RaihanRasheedApurbo. I have re-assigned you to this ticket and attached your PR to this ticket. We'll review this and get back to you.

@lauracumming
Copy link

I think this is okay - not sure what has changed.
There is still a bit of a delay sometimes but once save it's okay.

Image Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug volunteers Tasks that can be picked up by anyone
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants