Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture type of Emphasis/Strong in AST #214

Open
jfrolich opened this issue Jul 3, 2020 · 6 comments
Open

Capture type of Emphasis/Strong in AST #214

jfrolich opened this issue Jul 3, 2020 · 6 comments

Comments

@jfrolich
Copy link
Contributor

jfrolich commented Jul 3, 2020

Star or Underscore. This allows parsers to treat them slightly different.

@nojb
Copy link
Contributor

nojb commented Jul 3, 2020

Actually we supported this before and I removed it because I thought it was not useful. But I'm planning to put it back since it turns out it is useful for a number of things.

@nojb
Copy link
Contributor

nojb commented Jul 5, 2020

@jfrolich On further thought could you say a few words on what use-case you have in mind for this?

@jfrolich
Copy link
Contributor Author

jfrolich commented Jul 5, 2020

For compilation to ocamldoc which has 3 emphasis/strong/bold styles.

@nojb
Copy link
Contributor

nojb commented Jul 5, 2020

You mean {e text}, {b text} and {i text} ?

@jfrolich
Copy link
Contributor Author

jfrolich commented Jul 5, 2020

Yes. I figured we could stay in the markdown spec and still support these differences.

@nojb
Copy link
Contributor

nojb commented Jul 5, 2020

I see. I am a bit reticent to adding an extra field to the AST that will be ignored most of time... On the other hand, this may come in handy for the hypothetical markdown backend, so it may be worth it after all... I will give it a shot, but am not fully convinced yet :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants