eio_linux: fallback to fork if clone3 is unavailable #524
Conversation
`clone3` is blocked by Docker's default security policy. Also, use `(uintptr_t)` when storing a pointer in a `uint64_t` field, otherwise it doesn't work on 32-bit systems.
|
This does leave us in a strange half-way house, since we don't derive any benefit from using |
I was going to do that, but the fallback path requires some awkward code to handle the case where you spawn a process and then can't get an FD for it (e.g. due to FD limits), so I decided to use the new system when available. Also, I'm still planning to add support for namespaces at some point (it's OK if that doesn't work in a container). |
| return child_pid; /* Success! */ | ||
|
|
||
| if (errno != ENOSYS && errno != EPERM) { | ||
| uerror("clone3", Nothing); /* Unknown error */ |
There was a problem hiding this comment.
This needs to be fixed everywhere, not just here, but I believe the recommended function from OCaml 5 is caml_uerror so it's namespaced right. (see ocaml/ocaml@67a4d75).
There was a problem hiding this comment.
OK, let's do that in a separate PR.
clone3is blocked by Docker's default security policy.Also, use
(uintptr_t)when storing a pointer in auint64_tfield, otherwise it doesn't work on 32-bit systems.Fixes #514.