Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foundation.Mpsc_queue returns items in the wrong order #20

Closed
talex5 opened this issue Nov 17, 2023 · 1 comment · Fixed by #21
Closed

Foundation.Mpsc_queue returns items in the wrong order #20

talex5 opened this issue Nov 17, 2023 · 1 comment · Fixed by #21
Labels
bug Something isn't working

Comments

@talex5
Copy link

talex5 commented Nov 17, 2023 

utop # module Q = Foundation.Mpsc_queue;;
utop # let q = Q.create ();;
utop # Q.enqueue q 1;;
utop # Q.enqueue q 2;;
utop # Q.dequeue q;;
- : int = 2

I think the code is confused about the behaviour of List.rev_append. I noticed this while making ocaml-multicore/eio#647.
@polytypic
Copy link
Collaborator

Oops. Good catch! Thanks for the report.

@polytypic polytypic added the bug Something isn't working label Nov 27, 2023
@polytypic polytypic mentioned this issue Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Mpsc_queue order ocaml-multicore/picos
2 participants
@talex5 @polytypic