Add --exclude to exclude the given packages from the publishing process #161
Conversation
There was a problem hiding this comment.
I would simplify the type for ~exclude to be just string list, but more importantly I think the code should check that the exclusions refer to packages found (that would mean, for example, that --exclude opam-admni will fail instead of continuing to publish opam-admin anyway.
done |
| OpamConsole.error_and_exit `Not_found | ||
| "Excluded package '%s' not found" | ||
| (OpamPackage.Name.to_string name) |
There was a problem hiding this comment.
Why errorring instead of a warning and continue ?
There was a problem hiding this comment.
this was a request from David (see above). I think it's fair to error on this since it avoid issues for users later down the line if they do not see the warning or if the opam-publish is used as part of an automated system
There was a problem hiding this comment.
lgtm! Indeed, i looked at the code, didn't see David comment.
Fixes #144