Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wishlist for the 1.0 release #900

Closed
8 of 12 tasks
gpetiot opened this issue Jun 26, 2019 · 6 comments
Closed
8 of 12 tasks

Wishlist for the 1.0 release #900

gpetiot opened this issue Jun 26, 2019 · 6 comments
Milestone

Comments

@gpetiot
Copy link
Collaborator

gpetiot commented Jun 26, 2019

Default profile

  • make the conventional profile the default profile (currently it is the ocamlformat profile) (Improve: set conventional as the default profile #1060)
  • currently no profile is selected by default, it would contradict the default values of options, instead we need to specify whether an option-value belongs to a profile (wrong)

Sanitize options

OCaml ecosystem

Other improvements

@gpetiot gpetiot added this to the 1.0 milestone Jun 26, 2019
@gpetiot gpetiot pinned this issue Jun 26, 2019
@gpetiot gpetiot unpinned this issue Jul 23, 2019
@gpetiot gpetiot pinned this issue Jul 23, 2019
@vphantom
Copy link

vphantom commented Aug 8, 2019

(Redacted: it turns out that 0.11 changed break-separators = after-and-docked which now puts opening and closing on separate lines, minimizing editing and diffs. I hadn't seen that 0.11 was released when I wrote my initial comment.)

@gpetiot
Copy link
Collaborator Author

gpetiot commented Aug 8, 2019

Ocamlformat 0.11 has only been released this morning, I didn't have time to publish an official announcement yet.

@Wilfred
Copy link
Contributor

Wilfred commented Oct 8, 2019

I've left feedback on #932 regarding removal of options: I'm not sure if you just want to change the default or remove the option entirely.

@gpetiot
Copy link
Collaborator Author

gpetiot commented Oct 9, 2019

I've left feedback on #932 regarding removal of options: I'm not sure if you just want to change the default or remove the option entirely.

I submitted #1057 to address this.

@Et7f3 Et7f3 mentioned this issue May 8, 2020
@rbjorklin
Copy link
Contributor

I'm all for reducing the number of options but do want to leave my 2 cents before things get cemented. I'm not sure what's the right way of leaving feedback so I'm leaving a note here.

In a professional setting where one or more people review your code I've found it very helpful to have a more vertical style as it helps a lot with making it easier to spot the relevant part of a changed line during review.

I'm currently using this as my starting point:

break-cases = fit-or-vertical
break-infix = fit-or-vertical
break-fun-decl = fit-or-vertical
type-decl = sparse

@gpetiot
Copy link
Collaborator Author

gpetiot commented Oct 1, 2021

The roadmap is being rewritten, instead of having this meta-issue I will open issues with the remaining points for the 1.0 release and add them to the 1.0 milestone.
I'm closing this one.

@gpetiot gpetiot closed this as completed Oct 1, 2021
@gpetiot gpetiot unpinned this issue Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants