Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not compatible with jbuilder #18

Closed
smolkaj opened this issue Sep 18, 2017 · 2 comments
Closed

Not compatible with jbuilder #18

smolkaj opened this issue Sep 18, 2017 · 2 comments
Assignees
@xguerin

Comments

@smolkaj
Copy link

smolkaj commented Sep 18, 2017

Are there any plans to make this rewriter work with jbuilder? ppx_deriving now works with jbuilder since recently.
@whitequark
Copy link
Contributor

As soon as I find some time to figure out how jbuilder works, sure...

@xguerin xguerin self-assigned this Jan 16, 2018
@xguerin
Copy link
Contributor

xguerin commented Jan 16, 2018

I raised the question on the ML some time ago when I tried to port ppx_import to jbuilder. In short, jbuilder makes the hypothesis that PPX are self-contained, ie. that they don't have any external dependencies and especially not build artifacts.

So unless that changes, support for ppx_import is unlikely. For reference, see ocaml/dune#193.

@xguerin xguerin closed this as completed Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xguerin xguerin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@whitequark @xguerin @smolkaj