Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 11c3f20

Browse files
committedApr 27, 2021
Add a comment and a CHANGES entry
Signed-off-by: Andrey Mokhov <amokhov@janestreet.com>
1 parent 0bd8d56 commit 11c3f20

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed
 

‎CHANGES.md

+8
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,14 @@ Unreleased
120120

121121
- Fix a crash when clearing temporary directories (#4489, #4529, Andrey Mokhov)
122122

123+
- Dune now memoizes all errors when running in the file-watching mode. This
124+
speeds up incremental rebuilds but may be inconvenient in rare cases, e.g. if
125+
a build action fails due to a spurious error, such as running out of memory.
126+
Right now, the only way to force such actions to be rebuilt is to restart
127+
Dune, which clears all memoized errors. In future, we would like to provide a
128+
way to rerun all actions failed due to errors without restarting the build,
129+
e.g. via a Dune RPC call. (#4522, Andrey Mokhov)
130+
123131
2.9.0 (unreleased)
124132
------------------
125133

‎src/memo/memo.mli

+7
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
open! Stdune
22

3+
(* CR-someday amokhov: The current implementation memoizes all errors, which may
4+
be inconvenient in rare cases, e.g. if a build action fails due to a spurious
5+
error, such as running out of memory. Right now, the only way to force such
6+
actions to be rebuilt is to restart Dune, which clears all memoized errors.
7+
In future, we would like to provide a way to rerun all actions failed due to
8+
errors without restarting the build, e.g. via a Dune RPC call. *)
9+
310
type 'a build
411

512
module type Build = sig

0 commit comments

Comments
 (0)
Please sign in to comment.