Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy_files: should Dune error out if no files are found? #10646

Closed
jchavarri opened this issue Jun 13, 2024 · 1 comment · Fixed by #10649
Closed

copy_files: should Dune error out if no files are found? #10646

jchavarri opened this issue Jun 13, 2024 · 1 comment · Fixed by #10649

Comments

@jchavarri
Copy link
Collaborator

Right now, Dune is lenient in the way copy_files work. If I do:

(copy_files foo/bar.txt)

But if the file foo/bar.txt doesn't exist, Dune will proceed just fine, as far as I can tell.

I wonder if it should error out if no files to copy are found given a glob? So that users can also get some help to maintain their dune files clean and avoid wasteful work for Dune (parsing, resolving globs, looking for inexistent files...)

@rgrinberg
Copy link
Member

Raising an error in newer versions of dune seems fine. We could always introduce a mode to disable this check if somebody will need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants