Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track dependencies at the env level #1152

Closed
emillon opened this issue Aug 20, 2018 · 3 comments
Closed

Track dependencies at the env level #1152

emillon opened this issue Aug 20, 2018 · 3 comments
Assignees

Comments

@emillon
Copy link
Collaborator

emillon commented Aug 20, 2018

As discussed in #1147 (comment), we should track when (env) changes and trigger a rebuild in that case.

@emillon emillon self-assigned this Aug 20, 2018
@rgrinberg
Copy link
Member

Another thing that will be useful here is to add a way to get the environment at the action level. Naturally, this should respect the setenv action.

@rgrinberg
Copy link
Member

@emillon this can be closed now?

@emillon
Copy link
Collaborator Author

emillon commented Sep 21, 2018

Yes, that's mostly taken care of by #1186. I think setenv works correctly since the env is passed. The rest will be taken care of by #1147.

@emillon emillon closed this as completed Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants