-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to use future_syntax with dune 1.10.0 #2262
Comments
Apparently we don't expand %{bin} here, probably for no particular reason. As a workaround you could try something like this:
@mlasson, I'm told you know something about ppx flag expansion. |
Thanks @aalekseyev, that works perfectly |
@aalekseyev : Yes it would totally makes sense, but I think some thinking should be put into that. Currently, most macro are allowed only in actions (except for %{env} which feels like a hack). If we wanted to support more macros in preprocessors flags we would need to change the logic in order to delay the expansion at the build stage. Moreover, for consistency, we would probably want to do that for other kinds of flags. So this does not seem trivial to me (but I'm far from being an expert). Finally, if we want to go in that direction (and why not ?), we may want to support other macros that may add dependencies to the build (so we will need not to forget to collect them and record them). |
I'm not sure about the timeline here, but this has been fixed in #2076 (dune 1.10). Using |
I am attempting to use the new
ocaml-syntax-shims
with other preprocessors on dune 1.10.0but get the following error:
Reproducing example:
See also #1934
The text was updated successfully, but these errors were encountered: