Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when a rule fails to generate a target #903

Closed
rgrinberg opened this issue Jun 20, 2018 · 2 comments
Closed

Improve error message when a rule fails to generate a target #903

rgrinberg opened this issue Jun 20, 2018 · 2 comments

Comments

@rgrinberg
Copy link
Member

See this issue for an example. In the case where a rule fails to generate a target we get the fairly cryptic error:

Error: Rule failed to generate the following targets:
- src/unix/dlllwt_unix_stubs.so

It would be nice to improve this message by including the Action that tried to produce this target and possibly a location (if it exists). Right now, we have to dig through the build logs.

@diml I'm willing to improve this if you think this is a good idea. I haven't looked at the code yet, but it seems like this would be fairly simply. Any thing I need to keep in mind?

@ghost
Copy link

ghost commented Jun 20, 2018

I'm for it. I agree that it should be straightforward

@rgrinberg rgrinberg mentioned this issue Aug 4, 2018
@rgrinberg
Copy link
Member Author

This was fixed a while ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant