Skip to content

Commit ebe3abd

Browse files
authored
Merge pull request #1995 from Tim-ats-d/issue1517
Add a test to ensure the behavior showed in issue #1517 is no longer relevant
2 parents 59f2b8d + 81a577a commit ebe3abd

File tree

2 files changed

+36
-1
lines changed

2 files changed

+36
-1
lines changed

CHANGES.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ unreleased
55
- Fix completion not working for inlined records labels (#1978, fixes #1977)
66
- Perform buffer indexing only if the query requires it (#1990 and #1991)
77
- Stop unnecessarily forcing substitutions when initializing short-paths graph (#1988)
8-
8+
+ test suite
9+
- Add a test to ensure the behavior showed in issue #1517 is no longer relevant (#1995)
910

1011
merlin 5.6
1112
==========

tests/test-dirs/errors/issue1517.t

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
Ensure that the issue highlighted in issue #1517 is no longer relevant.
2+
See https://github.com/ocaml/merlin/issues/1517.
3+
4+
$ cat >main.ml <<EOF
5+
> type _ bar =
6+
> | Flag : int bar
7+
> | Other : 'a bar
8+
>
9+
> let foo : unit -> int bar -> unit =
10+
> fun () Other -> ()
11+
> EOF
12+
13+
$ $MERLIN single errors -filename main.ml < main.ml
14+
{
15+
"class": "return",
16+
"value": [
17+
{
18+
"start": {
19+
"line": 6,
20+
"col": 9
21+
},
22+
"end": {
23+
"line": 6,
24+
"col": 14
25+
},
26+
"type": "warning",
27+
"sub": [],
28+
"valid": true,
29+
"message": "Warning 8: this pattern-matching is not exhaustive.
30+
Here is an example of a case that is not matched: Flag"
31+
}
32+
],
33+
"notifications": []
34+
}

0 commit comments

Comments
 (0)