Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merlin + dune : merlin should get the stdlib path from dune #1255

Closed
nojb opened this issue Feb 2, 2021 · 2 comments
Closed

merlin + dune : merlin should get the stdlib path from dune #1255

nojb opened this issue Feb 2, 2021 · 2 comments

Comments

@nojb
Copy link
Contributor

nojb commented Feb 2, 2021

Currently merlin gets the stdlib path from the compiler that was used to compile merlin itself. This is quite inconvenient because this means that merlin cannot be used with any other compiler (of the same version). In our setting, we use a deploy a precompiled version of merlin in all our developer machines and we used to make this work using an explicit directive in .merlin but this doesn't work anymore with the new .merlin-less plumbing.

Since merlin already queries dune for a bunch of information, why not get the path to the standard library as well from it? You can see the stdlib location that dune uses when you do dune build --verbose.

@trefis
Copy link
Contributor

trefis commented Feb 3, 2021

I agree with you, and merlin still understands that directive (the STDLIB one in `.merlin files), so I don't think there's anything to do on our side. It's just that dune isn't giving it to merlin.
I suggest you open an issue there :)

@nojb
Copy link
Contributor Author

nojb commented Feb 3, 2021

I agree with you, and merlin still understands that directive (the STDLIB one in `.merlin files), so I don't think there's anything to do on our side. It's just that dune isn't giving it to merlin.
I suggest you open an issue there :)

Thanks! For future reference, here it is ocaml/dune#4188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants