Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does rename work with syntax like [%sedlex.regexp? '0' .. '9'] #1501

Open
liweijian opened this issue Jul 24, 2022 · 1 comment
Open

Does rename work with syntax like [%sedlex.regexp? '0' .. '9'] #1501

liweijian opened this issue Jul 24, 2022 · 1 comment

Comments

@liweijian
Copy link

The case was from sedlex, which looks like:

image

@voodoos
Copy link
Collaborator

voodoos commented Aug 2, 2022

They have been multiple reports regarding weirdness happening when using ppxes. Merlin doesn't do a lot more than calling the ppx on the parse-tree before performing analysis over the result. If the ppx returns incorrect locations in the parse-tree then Merlin cannot work properly and there is not a lot of room for us to improve.

On the other, in this example, hand it looks like the editor should be able to perform some trivial renaming here, except if the file is read-only. It might be worth it to report that issue to the vscode-ocaml-platform people since it feels like the editor should fallback to the built-in renaming system if Merlin cannot provide the occurrences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants