Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_oasis_remove_.ml and OASIS version of setup.ml #30

Closed
gildor478 opened this issue Dec 9, 2016 · 4 comments
Closed

_oasis_remove_.ml and OASIS version of setup.ml #30

gildor478 opened this issue Dec 9, 2016 · 4 comments

Comments

@gildor478
Copy link
Member

Pre-emptive bug, I don't yet have the issue.

I see in commit 77b07e3, that you have removed the generation of oasis_remove.ml (which is a good thing).

The problem is that '-C' is only fixed with OASIS 0.4.7 and you may have a setup.ml generated with former version (e.g. 0.4.6).

Can you check the version of OASIS used to generate setup.ml and issue an error if < 0.4.7 ?

To check the version

$ ocaml setup.ml -version
@Chris00
Copy link
Member

Chris00 commented Dec 9, 2016

Good remark. Since I use the OASIS lib, I guess it is possible to have that info from the library, right?

@Chris00
Copy link
Member

Chris00 commented Dec 9, 2016

I could detect that because the module Compat_0_4 is present, right? At the moment, I do not execute anything from the tarball and I would like it to stay that way.

@gildor478
Copy link
Member Author

No. This is embedded into one of the record field deep inside the auto-generated setup.ml.

This is actually unfortunate, because I know it would be useful to auto-extract it, without running setup.ml.

  1. I think a quick fix for oasis2opam is to check with ocaml setup.ml -version.
  2. You have unstructured data in setup.ml which reads like "Regenerated by OASIS (.*)" , but it is unstructured data, although you can probably easily extract it with a regex.
  3. l and I have created a feature request to implement what is needed (metadata in setup.ml) in the next version of OASIS.

@Chris00
Copy link
Member

Chris00 commented Dec 9, 2016

I used 2. because I would prefer not to have to trust the setup.ml file. :-)

@Chris00 Chris00 closed this as completed in 5ccbd55 Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants