Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement to the Multicore Example in Playground #824

Closed
sabine opened this issue Jan 17, 2023 · 2 comments
Closed

Improvement to the Multicore Example in Playground #824

sabine opened this issue Jan 17, 2023 · 2 comments
Labels
enhancement New feature or request playground

Comments

@sabine
Copy link
Collaborator

sabine commented Jan 17, 2023

There were concerns about the multicore Fibonacci code example misrepresenting the skills of OCaml programmers, as it shows an inefficient implementation.

Suggestion from discuss.ocaml.org:

Rename the function to naive_fib and point to this URL in a comment just above the function name?

See: OPCEB chapter 8 on memoization for a more performant implementation
@sabine sabine added enhancement New feature or request playground labels Jan 17, 2023
@cuihtlauac
Copy link
Collaborator

Relevant discussion on twitter: https://twitter.com/wicko3/status/1482042995138600960

@cuihtlauac
Copy link
Collaborator

Possible duplicate of: #233

@sabine sabine mentioned this issue Jan 17, 2023
Merged
@sabine sabine closed this as completed Jan 19, 2023
@tmattio tmattio moved this to ✅ Done in OCaml.org Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request playground
Projects
OCaml.org
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cuihtlauac @sabine