Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test nested HTML pages #213

Closed
rizo opened this issue Oct 9, 2018 · 3 comments
Closed

Test nested HTML pages #213

rizo opened this issue Oct 9, 2018 · 3 comments
Labels
output stale

Comments

@rizo
Copy link
Collaborator

rizo commented Oct 9, 2018

Currently the HTML tests only cover the root module M/index.html page. The nested sub-pages are simply ignored. We can adapt the diffing to iterate on the full tree in the expect directory and validate it with the contents generated in _scratch.
rizo referenced this issue Oct 9, 2018
@rizo
Move top doc for nested items to header similar to root module.
9c98b4c
@aantron aantron added the output label Oct 12, 2018
@rizo rizo mentioned this issue Dec 3, 2018
Merged
@rizo
Copy link
Collaborator Author

rizo commented Dec 3, 2018

FYI there are currently 48 HTML "nested" files not covered by tests:

_build/default/test/html/_scratch/test_package+ml/Class/class-mutually'/index.html
_build/default/test/html/_scratch/test_package+ml/Class/class-recursive'/index.html
_build/default/test/html/_scratch/test_package+ml/Class/class-type-empty/index.html
_build/default/test/html/_scratch/test_package+ml/Class/class-type-mutually/index.html
_build/default/test/html/_scratch/test_package+ml/Class/class-type-recursive/index.html
_build/default/test/html/_scratch/test_package+ml/Functor/F1/argument-1-Arg/index.html
_build/default/test/html/_scratch/test_package+ml/Functor/F1/index.html
_build/default/test/html/_scratch/test_package+ml/Functor/F2/argument-1-Arg/index.html
_build/default/test/html/_scratch/test_package+ml/Functor/F2/index.html
_build/default/test/html/_scratch/test_package+ml/Functor/F3/argument-1-Arg/index.html
_build/default/test/html/_scratch/test_package+ml/Functor/F3/index.html
_build/default/test/html/_scratch/test_package+ml/Functor/F4/argument-1-Arg/index.html
_build/default/test/html/_scratch/test_package+ml/Functor/F4/index.html
_build/default/test/html/_scratch/test_package+ml/Functor/module-type-S/index.html
_build/default/test/html/_scratch/test_package+ml/Functor/module-type-S1/argument-1-_/index.html
_build/default/test/html/_scratch/test_package+ml/Functor/module-type-S1/index.html
_build/default/test/html/_scratch/test_package+ml/Include/module-type-Inlined/index.html
_build/default/test/html/_scratch/test_package+ml/Include/module-type-Not_inlined/index.html
_build/default/test/html/_scratch/test_package+ml/Include/module-type-Not_inlined_and_closed/index.html
_build/default/test/html/_scratch/test_package+ml/Include/module-type-Not_inlined_and_opened/index.html
_build/default/test/html/_scratch/test_package+ml/Module/M'/index.html
_build/default/test/html/_scratch/test_package+ml/Module/module-type-S/index.html
_build/default/test/html/_scratch/test_package+ml/Module/module-type-S/M/index.html
_build/default/test/html/_scratch/test_package+ml/Module/module-type-S1/index.html
_build/default/test/html/_scratch/test_package+ml/Module/module-type-S2/index.html
_build/default/test/html/_scratch/test_package+ml/Module/module-type-S2/M/index.html
_build/default/test/html/_scratch/test_package+ml/Module/module-type-S3/index.html
_build/default/test/html/_scratch/test_package+ml/Module/module-type-S3/M/index.html
_build/default/test/html/_scratch/test_package+ml/Module/module-type-S4/index.html
_build/default/test/html/_scratch/test_package+ml/Module/module-type-S4/M/index.html
_build/default/test/html/_scratch/test_package+ml/Module/module-type-S5/index.html
_build/default/test/html/_scratch/test_package+ml/Module/module-type-S5/M/index.html
_build/default/test/html/_scratch/test_package+ml/Module/module-type-S6/index.html
_build/default/test/html/_scratch/test_package+ml/Module/module-type-S6/M/index.html
_build/default/test/html/_scratch/test_package+ml/Module/module-type-S7/index.html
_build/default/test/html/_scratch/test_package+ml/Module/module-type-S8/index.html
_build/default/test/html/_scratch/test_package+ml/Module/module-type-S8/M/index.html
_build/default/test/html/_scratch/test_package+ml/Module/module-type-S9/index.html
_build/default/test/html/_scratch/test_package+ml/Module/Mutually/index.html
_build/default/test/html/_scratch/test_package+ml/Module/Recursive/index.html
_build/default/test/html/_scratch/test_package+ml/Nested/class-z/index.html
_build/default/test/html/_scratch/test_package+ml/Nested/module-type-Y/index.html
_build/default/test/html/_scratch/test_package+ml/Nested/X/index.html
_build/default/test/html/_scratch/test_package+ml/Recent/module-type-S/index.html
_build/default/test/html/_scratch/test_package+ml/Recent/module-type-S1/argument-1-_/index.html
_build/default/test/html/_scratch/test_package+ml/Recent/module-type-S1/index.html
_build/default/test/html/_scratch/test_package+ml/Stop/N/index.html
_build/default/test/html/_scratch/test_package+ml/Type/module-type-X/index.html

@rizo rizo mentioned this issue Dec 6, 2018
Merged
2 tasks
@rizo
Copy link
Collaborator Author

rizo commented Dec 10, 2018

Update: testing nested HTML pages is now possible after #266. Fixing this issue will require reviewing the untracked files and including the important ones.

@github-actions
Copy link

github-actions bot commented May 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label May 1, 2020
@github-actions github-actions bot closed this as completed May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
output stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rizo @aantron