Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds of opam from git tags should not treat themselves as dev versions #4656

Closed
dra27 opened this issue May 10, 2021 · 0 comments · Fixed by #4665
Closed

Builds of opam from git tags should not treat themselves as dev versions #4656

dra27 opened this issue May 10, 2021 · 0 comments · Fixed by #4665
Assignees
Milestone

Comments

@dra27
Copy link
Member

dra27 commented May 10, 2021

Related to #4554 (comment), this has come up with the docker-base-images at ocaml/opam as well. If opam config report includes a git sha with the version of opam then that opam binary regards it itself as a dev version. This is problematic for hard upgrades, as these always prompt interactively on dev versions.

It's also philosophically problematic that a release tarball builds different from an otherwise identical checkout of the release tag in a git repository.

The solution: if git describe --exact reveals that this is a tag, treat it as a release (cf. the use of VERSION to do very similar, just by hand, in ocaml/ocaml)

@dra27 dra27 added this to the 2.0.9 milestone May 10, 2021
@dra27 dra27 self-assigned this May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant