Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid double symlink in archive cache #6100

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Jul 16, 2024

pro: have a cleaner cache by avoiding double symlinks (e.g. md5 -> sha512 & sha256 -> sha512 instead of md5 -> sha256 -> sha512)
cons: when the cache contains a sha256 -> md5 link, installing 2 packages that refer to the same archive but one with an md5 and the other with a sha256 ; the one with a sha256 won't be found in cache and redownloaded.

Another solution is to have opam always compute and store all checksums linked (from sha*'s), like proposed by @kit-ty-kate.

rjbou and others added 3 commits July 15, 2024 20:16
It is separated because on Linux and MacOS archives are soft linked and on Windows they are copied.
@rjbou rjbou added the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Jul 16, 2024
@kit-ty-kate kit-ty-kate removed the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants