Avoid double symlink in archive cache #6100
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pro: have a cleaner cache by avoiding double symlinks (e.g.
md5 -> sha512
&sha256 -> sha512
instead ofmd5 -> sha256 -> sha512
)cons: when the cache contains a
sha256 -> md5
link, installing 2 packages that refer to the same archive but one with an md5 and the other with a sha256 ; the one with a sha256 won't be found in cache and redownloaded.Another solution is to have opam always compute and store all checksums linked (from sha*'s), like proposed by @kit-ty-kate.