Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new failures on windows? #264

Closed
c-cube opened this issue Sep 26, 2021 · 5 comments · Fixed by #274
Closed

new failures on windows? #264

c-cube opened this issue Sep 26, 2021 · 5 comments · Fixed by #274
Labels
bug Something isn't working

Comments

@c-cube
Copy link

c-cube commented Sep 26, 2021

since 4.13 was released, I've started seeing this kind of failure, where setup-ocaml tries to install ocaml 4.13 but fails (even on switches explicitly using another version of the compiler).

@shonfeder
Copy link

We are seeing the same kind of failure, but for 4.12:

ocaml-variants = 4.12.1+mingw64c no matching version

https://github.com/ocaml/omd/pull/254/checks?check_run_id=3710546953#step:3:589

@dra27
Copy link
Member

dra27 commented Sep 26, 2021

For 4.13, it's (genuinely!) great that systems are so ready the weekend after the release! Unfortunately, that's caught us out slightly with discontinuation of fdopen/opam-repository-mingw.

This affects 4.12.1 and 4.13.0 - it should be temporarily possible to work around this by forcing 4.12.0 for Windows in your build matrix and removing 4.13.0.

I'm in the process of sorting out the formal upstreaming of Windows support to ocaml-base-compiler in ocaml/opam-repository (actually working on it yesterday, as part of a demo for cloneable compiler for opam on Tuesday), but I'll try to put a temporary update of the patches together for setup-ocaml to use either this evening or tomorrow.

@smorimoto
Copy link
Member

In the short term, fdopen/opam-repository-mingw@2b57e0d should have fixed things. In the long term, I will fix this with #263...

@smorimoto smorimoto added the bug Something isn't working label Sep 27, 2021
@smorimoto smorimoto linked a pull request Oct 1, 2021 that will close this issue
@smorimoto
Copy link
Member

The new release contains a fix for this issue. So it will not happen in future releases. Thanks for the report!

@shonfeder
Copy link

Thanks for the fix!

@c-cube c-cube mentioned this issue Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants