Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opam 2.2 support on Windows #793

Closed
kit-ty-kate opened this issue May 15, 2024 · 2 comments · Fixed by #794
Closed

opam 2.2 support on Windows #793

kit-ty-kate opened this issue May 15, 2024 · 2 comments · Fixed by #794
Labels
enhancement New feature or request

Comments

@kit-ty-kate
Copy link
Member

The following code

setup-ocaml/packages/setup-ocaml/src/constants.ts

Lines 45 to 46 in 1903ece

export const ALLOW_PRERELEASE_OPAM =
PLATFORM !== "win32" &&
disallows the use of the latest opam beta which is compatible with Windows.

Would it be possible to remove this conditional?
@hhugo
Copy link
Contributor

hhugo commented May 15, 2024

One need to change acquireOpamWindows to take the pre release into account

@kit-ty-kate kit-ty-kate mentioned this issue May 15, 2024
Merged
@smorimoto
Copy link
Member

This is related to this issue: #733

@smorimoto smorimoto added the enhancement New feature or request label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add initial support for opam 2.2 on Windows kit-ty-kate/setup-ocaml
3 participants
@hhugo @kit-ty-kate @smorimoto