Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for autocompleting record fields when the source of the record is in a different module #256

Closed
jfrolich opened this issue Jun 15, 2020 · 11 comments

Comments

@jfrolich
Copy link

This works in OCaml, but it doesn't work in Reason. I think it, therefore, has to do with the reason syntax JSON file.

See: ocaml/merlin#1140 (comment)

@imbsky @rgrinberg

@mnxn
Copy link
Collaborator

mnxn commented Jun 15, 2020

The JSON syntax files in this repository are only used for syntax highlighting so they are unlikely to be the culprit.

I believe this is a problem in either ocaml/merlin or ocaml/ocaml-lsp.

@jfrolich
Copy link
Author

On discord @rgrinberg expressed that his guess is, the problem is in https://github.com/let-def/merlin-extend.

@rgrinberg
Copy link
Contributor

Actually, it's more likely that the issue is with merlin-extend reason plugin itself. That resides somewhere in the reason repository I think.

@jfrolich
Copy link
Author

https://github.com/facebook/reason/blob/master/src/reason-merlin/ocamlmerlin_reason.cppo.ml << this file?

@smorimoto
Copy link
Collaborator

I think this issue has no relation with this repository.

@jfrolich
Copy link
Author

jfrolich commented Jul 1, 2020

I opened an issue on the Reason repo. Can we leave this open until we know for sure it's related to reason-merlin?

@smorimoto
Copy link
Collaborator

Sure.

@jfrolich
Copy link
Author

jfrolich commented Jul 9, 2020

This started to work for me again (or I might have completely missed it before). The problem is that the field suggestions are all the way at the very bottom of the list (after all possible types and modules in the project etc.). I guess that is something that can be fixed in the plugin?

@jfrolich
Copy link
Author

Actually it still doesn't work in most cases.

@rgrinberg
Copy link
Contributor

Is this still a problem? It seems to be a problem only with the reason frontend, which isn't maintained in this repository.

@jfrolich
Copy link
Author

jfrolich commented Nov 2, 2020

Yes. I seems to be a problem in reason-merlin. You can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants