Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra wrapping in op:start-session.acceptable-location-sig #3

Open
dpwiz opened this issue Aug 7, 2023 · 1 comment
Open

Extra wrapping in op:start-session.acceptable-location-sig #3

dpwiz opened this issue Aug 7, 2023 · 1 comment

Comments

@dpwiz
Copy link

dpwiz commented Aug 7, 2023

The spec says:

The acceptable-location-sig is the signature of the serialized acceptable-location.

However, the code wraps the acceptable-location in an extra record: <my-location [...]>.

@tsyesika
Copy link
Contributor

Yeah, you're right. I think I initially left it off because I believed it was unnecessary and should rather be changed in goblins, however I spoke to Christine a while ago about it and she explained why this is needed. Basically that if you sign something without providing the context in which you're signing it, it could potentially be used in other contexts by someone else.

I'll update the spec to align with how this actually works in both Goblins and the test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants