Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: The parentheses for database changes are in English #2345

Closed
sl01388797 opened this issue May 9, 2024 · 4 comments · Fixed by #2351 or #2579
Closed

[Bug]: The parentheses for database changes are in English #2345

sl01388797 opened this issue May 9, 2024 · 4 comments · Fixed by #2351 or #2579
Assignees
@smallsheeeep
Labels
Issues found during testing priority-medium type-bug Something isn't working
Milestone
ODC 4.3.0

Comments

@sl01388797
Copy link
Collaborator

ODC version

odc424

OB version

What happened?

image

What did you expect to happen?

Brackets in Chinese

How can we reproduce it (as minimally and precisely as possible)?

Execute database changes

Anything else we need to know?

No response
@sl01388797 sl01388797 added type-bug Something isn't working priority-medium labels May 9, 2024
@sl01388797 sl01388797 added this to the ODC 4.2.4-bp2 milestone May 9, 2024
@sl01388797 sl01388797 changed the title [Bug]: 数据库变更的中括号为英文 [Bug]: The parentheses for database changes are in English May 9, 2024
@yhilmare
Copy link
Contributor

yhilmare commented May 9, 2024

this bug is involved by this pr #1941

@yhilmare
Copy link
Contributor

yhilmare commented May 9, 2024

截屏2024-05-09 22 09 43 截屏2024-05-09 22 14 27

Both Chinese and English are fine~

@yhilmare yhilmare mentioned this issue May 9, 2024
Merged
@yhilmare yhilmare linked a pull request May 9, 2024 that will close this issue
enhancement(partition-plan): add a prompt when no preview sql generated #2351
Merged
@tonghan-gsh
Copy link
Collaborator

Image

pass

@yhilmare yhilmare reopened this May 10, 2024
@tonghan-gsh tonghan-gsh modified the milestones: ODC 4.2.4-bp2, ODC 4.3.0 May 13, 2024
@yhilmare yhilmare assigned smallsheeeep and unassigned yhilmare May 29, 2024
@smallsheeeep smallsheeeep mentioned this issue May 30, 2024
Merged
@smallsheeeep smallsheeeep linked a pull request May 30, 2024 that will close this issue
fix(ticket): wrong i18n description for task #2579
Merged
@sl01388797
Copy link
Collaborator Author

Image

PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smallsheeeep smallsheeeep

Labels
Issues found during testing priority-medium type-bug Something isn't working
Projects
ODC
Archived in project
Milestone
ODC 4.3.0
5 participants
@yhilmare @MarkPotato777 @tonghan-gsh @smallsheeeep @sl01388797