Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OFCL correction with CARQ should use "hr-0" forecast #65

Closed
SorooshMani-NOAA opened this issue Mar 10, 2023 · 0 comments · Fixed by #68
Closed

OFCL correction with CARQ should use "hr-0" forecast #65

SorooshMani-NOAA opened this issue Mar 10, 2023 · 0 comments · Fixed by #68
Assignees

Comments

@SorooshMani-NOAA
Copy link
Collaborator

The correction logic implemented in

@unfiltered_data.setter
def unfiltered_data(self, dataframe: DataFrame):

for fixing OFCL track based on CARQ gets the first entry of CARQ in the given track_start_time:

for initial_time, forecast in ofcl_tracks.items():
if initial_time in carq_tracks:
carq_forecast = carq_tracks[initial_time]
else:
carq_forecast = carq_tracks[list(carq_tracks)[0]]

This results doesn't return values from 0 hour forecast (e.g. it might return -24 hour forecast):

AL, 06, 2018091306, 01, CARQ, -24, 287N,  695W, 115,    0, HU,  34, AAA,    0,    0,    0,    0,    0,    0,   0,   0,   0,   L,   0,   X,   0,   0,   FLORENCE,  , 
AL, 06, 2018091306, 01, CARQ, -18, 294N,  707W, 115,    0, HU,  34, AAA,    0,    0,    0,    0,    0,    0,   0,   0,   0,   L,   0,   X,   0,   0,   FLORENCE,  , 
AL, 06, 2018091306, 01, CARQ, -12, 304N,  719W, 110,    0, HU,  34, AAA,    0,    0,    0,    0,    0,    0,   0,   0,   0,   L,   0,   X, 315,  15,   FLORENCE,  , 
AL, 06, 2018091306, 01, CARQ,  -6, 315N,  732W, 100,    0, HU,  34, AAA,    0,    0,    0,    0,    0,    0,   0,   0,   0,   L,   0,   X,   0,   0,   FLORENCE,  , 
AL, 06, 2018091306, 01, CARQ,   0, 325N,  743W,  95,  956, HU,  34, NEQ,  170,  150,  110,  140, 1013,  200,  25,   0,   0,   L,   0,   X, 315,  15,   FLORENCE, D, 
AL, 06, 2018091306, 01, CARQ,   0, 325N,  743W,  95,  956, HU,  50, NEQ,  100,   90,   70,   80, 1013,  200,  25,   0,   0,   L,   0,   X, 315,  15,   FLORENCE, D, 
AL, 06, 2018091306, 01, CARQ,   0, 325N,  743W,  95,  956, HU,  64, NEQ,   70,   60,   50,   60, 1013,  200,  25,   0,   0,   L,   0,   X, 315,  15,   FLORENCE, D, 

Instead the logic should be to pick the forecast_hours == 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant