Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 0x prefix from agreementId on computeStatus query string #1892

Open
paulo-ocean opened this issue Dec 5, 2024 · 1 comment
Open
Assignees
Labels
Type: Bug Something isn't working Type: Enhancement New feature or request

Comments

@paulo-ocean
Copy link
Contributor

paulo-ocean commented Dec 5, 2024

See related issue on node:
oceanprotocol/ocean-node#776
for reference and details
We should not remove the 0x prefix from the agreementId on V4
This was done because of an issue that existed on provider

let url = `?consumerAddress=${consumerAddress}`
    url += (agreementId && `&agreementId=${this.noZeroX(agreementId)}`) || ''
    url += (jobId && `&jobId=${jobId}`) || ''

the noZeroX will not be needed on release V4

@paulo-ocean paulo-ocean added Type: Bug Something isn't working Type: Enhancement New feature or request labels Dec 5, 2024
@paulo-ocean paulo-ocean changed the title Remove 0x prefix from agreementId on computeStatus Remove 0x prefix from agreementId on computeStatus query string Dec 5, 2024
@paulo-ocean
Copy link
Contributor Author

this will be fixed as part of #1891

@paulo-ocean paulo-ocean self-assigned this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant