[pdr-trueval] All latest txs are crashing with "Already settled"

[trentmc]

Background

[Alex in slack]:

All latest txs are crashing with "Already settled". See:

• https://explorer.oasis.io/mainnet/sapphire/tx/0x177c0c75a656c70410688dfcb248e99d1bbd64e18e6325426872164ec23f0912
• https://explorer.oasis.io/mainnet/sapphire/tx/0x48b636c243cb9ed6906491bdbc62b4e19e48f19310801f6e9023ed5517425d9e
• https://explorer.oasis.io/mainnet/sapphire/tx/0x980972d3608f321d98640314634727135d6b6a8c4951c38430ed4c01f24ad707

And nr of pending truevals is increasing:

this is mostly due to some incorrect subgraph/trueval code

Proposal:

1. check each round before submitting (In addition to subgraph results)
2. do it 1 tx / round (gas inefficient )

so, officially, predictoor is down

and keeps increasing:

[Norbert]: So if pdr-buyer is up again should be fine for people to keep submitting right? The should still get the rewards. We just need to fix pdr-trueval so slots become claimable.

[Alex] : I don't know if we can fix pdr-trueval before slots are being canceled.. then it's just wasted gas

[Norbert] : uh, and when is a slot canceled? I thought that is only if price doesn't change.

[Alex] : or pdr-trueval does not submit trueval in a certain interval

[Norbert] : Ok, how can I help? I'm not familiar with df-buyer but I could try.

[alexcos20]

This PR might fix it on subgraph side
But never the less, pdr-trueval should check slots status before submit, and not trust blindly the subgraph

[trentmc]

This PR might fix it on subgraph side But never the less, pdr-trueval should check slots status before submit, and not trust blindly the subgraph

Great stuff with the fast turnaround! Fingers crossed that this subgraph PR works.

If yes, I will revise this issue to focus on "check slots status before submit, and not trust blindly the subgraph". And aim to do this after yaml-cli2 branch is merged. (Next Mon at soonest.)

[trizin]

#431 should fix on pdr-backend trueval side

[trentmc]

Fixed via ticket #430