Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send-prevents-chat-reports-to-client not working #53

Closed
Brottweiler opened this issue Jul 7, 2024 · 7 comments · Fixed by #55
Closed

send-prevents-chat-reports-to-client not working #53

Brottweiler opened this issue Jul 7, 2024 · 7 comments · Fixed by #55
Labels
question Further information is requested

Comments

@Brottweiler
Copy link

Does send-prevents-chat-reports-to-client still work? In 1.20.6 and 1.21 my experience is that the icon does not show up in the server list. It shows up on a 1.20.4 server however.

@pop4959 pop4959 added the question Further information is requested label Jul 8, 2024
@pop4959
Copy link
Collaborator

pop4959 commented Jul 8, 2024

In theory it's still supported as we re-write this packet to include the preventsChatReports field for mods that accept that. Unless that isn't working, or something else changed here. I will admit I am not really familiar with this, so it has not really been tested thoroughly, and it's entirely possible it could be broken, though no one has complained yet about it until now.

It would help me out if you can explain what you are doing to see this icon in the server list, and how it differs between older versions and the current version.

@Brottweiler
Copy link
Author

Brottweiler commented Jul 8, 2024

I am running No Chat Reports Fabric-1.21-v2.8.0 on the client and FreedomChat on the server. I run the latest version for 1.20.4, 1.20.6 and 1.21 respectively (1.21 version I took from GitHub actions). The icon in the server list shows up only for the 1.20.4 server (and all previous versions in the past), but since 1.20.6 the icon will not show up in the server list.

I am using 1.21 on the client, with ViaFabricPlus, which makes me able to join the 1.20.4 server. But the 1.20.4 server also runs ViaVersion so I can join with 1.21 even without ViaFabricPlus, but the point is that the icon still shows up for the 1.20.4 server just fine.

I hope that helps. I'm thinking no one else reported it because the option is off by default and maybe not used by many.

@pop4959
Copy link
Collaborator

pop4959 commented Jul 8, 2024

Yeah I don't think it's used by many people. I did specifically update this to maintain the feature when we updated to 1.20.6 though, so if it broke, that'd be when. I'll take a look when I get a chance (or if anyone else would like to before I end getting around to this, feel free).

@CompeyDev
Copy link

Yep, facing this too. Please lmk when this is fixed!

@pop4959
Copy link
Collaborator

pop4959 commented Jul 16, 2024

@Brottweiler @CompeyDev Please check and confirm that this works for you in the latest build - should be fixed now thanks to @whiler-sesame finding the issue here.

@CompeyDev
Copy link

Can confirm - it works!

@Brottweiler
Copy link
Author

All good now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants