Skip to content

Commit f0ea330

Browse files
committed
fix thinking models + tool calls (</think> not part of trigger's capture!)
1 parent bb7b9fe commit f0ea330

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

common/chat.cpp

-2
Original file line numberDiff line numberDiff line change
@@ -1137,7 +1137,6 @@ static common_chat_params common_chat_params_init_deepseek_r1(const common_chat_
11371137
// Distill Qwen 7B & 32B models seem confused re/ syntax of their tool call opening tag,
11381138
// so we accept common variants (then it's all constrained)
11391139
builder.add_rule("root",
1140-
std::string(data.thinking_forced_open ? "\"</think>\" space " : "") +
11411140
"( \"<|tool▁calls▁begin|>\" | \"<|tool_calls_begin|>\" | \"<|tool calls begin|>\" | \"<|tool\\\\_calls\\\\_begin|>\" | \"<|tool▁calls|>\" ) "
11421141
"(" + string_join(tool_rules, " | ") + ")" + (inputs.parallel_tool_calls ? "*" : "") + " "
11431142
"\"<|tool▁calls▁end|>\""
@@ -1427,7 +1426,6 @@ static common_chat_params common_chat_params_init_hermes_2_pro(const common_chat
14271426
"( \"```\\n\" | \"```json\\n\" | \"```xml\\n\" ) space " + wrappable_tool_call + " space \"```\" space ");
14281427
auto tool_call = builder.add_rule("tool_call", string_join(tool_call_alts, " | "));
14291428
builder.add_rule("root",
1430-
std::string(data.thinking_forced_open ? "\"</think>\" space " : "") +
14311429
(inputs.parallel_tool_calls ? "(" + tool_call + ")+" : tool_call));
14321430
// Trigger on some common known "good bad" outputs (only from the start and with a json that's about a specific argument name to avoid false positives)
14331431
data.grammar_triggers.push_back({

0 commit comments

Comments
 (0)