Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix to id of getContacts and possibly others #14

Open
demurgos opened this issue May 24, 2016 · 3 comments
Open

Add prefix to id of getContacts and possibly others #14

demurgos opened this issue May 24, 2016 · 3 comments

Comments

@demurgos
Copy link
Member

The contacts returned by .getContacts should be prefixed by their type (as 8: for human users).

@mitchcapper
Copy link
Collaborator

Not sure if we want to extend this to other methods that return id's without being prefixed. Do we just assume a non-prefixed id is type 8?

@mitchcapper mitchcapper self-assigned this May 19, 2017
@mitchcapper mitchcapper changed the title Add prefix to id of getContacts Add prefix to id of getContacts and possibly others May 19, 2017
@mitchcapper mitchcapper removed their assignment May 19, 2017
@demurgos
Copy link
Member Author

demurgos commented May 29, 2017

I think that we need more data about this. Its better to not prefix rather than incorrectly prefix by 8:. I don't know if it is possible or safe to guess the type.

By the way, it seems that a "prefixed" ID is called a "MRI" by Skype (M... Resource Identifier ? M could be related to "Model"). Maybe it would be good to clearly state when the argument or result uses (non-prefixed) IDs or (prefixed) MRIs because it is currently confusing.

@demurgos
Copy link
Member Author

demurgos commented Jan 13, 2018

@mitchcapper
It's better to add the prefix everywhere. With the new contacts API (v2), Skype uses it as the only ID for the contacts.
We now only have {mri: "8:bob", ...} instead of the old {id: "bob", type: "skype", ...}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants