Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setTranslation merge option only emits new Translations triggering MissingTranslationHandler for existing translations #367

Closed
arnoabraham opened this issue Dec 20, 2016 · 2 comments

Comments

@arnoabraham
Copy link
Contributor

arnoabraham commented Dec 20, 2016

I'm submitting a ... (check one with "x")

[X] bug report => check the FAQ and search github for a similar issue or PR before submitting
[ ] support request => check the FAQ and search github for a similar issue before submitting
[X] feature request

Current behavior
setTranslation emits the new added translations if being merged, resulting in MissingTranslation errors of already existing translations.

Expected/desired behavior
setTranslations emits the merged object of all the translations instead of the new translations.

Reproduction of the problem
If the current behavior is a bug or you can illustrate your feature request better with an example, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:btpW3l0jr5beJVjohy1Q).

What is the expected behavior?
setTranslations emits the merged object of all the translations instead of the new translations.

What is the motivation / use case for changing the behavior?
Adding new translations dynamicly to the list using setTranslations(lang, translations, true) triggers the MissingTranslationHandler for translations that are already existing because only the newly added translations are emitted

Possible solution:
this.onTranslationChange.emit({translations: translations, lang: lang});

becomes:
this.onTranslationChange.emit({translations: this.translations[lang], lang: lang});

Please tell us about your environment:

  • ng2-translate version: 4.2.0

  • Angular version: 2.2.1

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

  • Language: [all | TypeScript X.X | ES6/7 | ES5]

@ocombe
Copy link
Member

ocombe commented Dec 20, 2016

Oh good catch, thanks !

@arnoabraham
Copy link
Contributor Author

#368 Created a pull request for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants