ocLazyload will load already loaded component if application is launched by angular.bootstrap

[merlinchen]

I put a simple example in this plunker to illustrate the problem.

The application and lazyloadModule both require 'sharedModule'.

angular.module('sharedModule', [])
    .directive('sharedDirective', [function () {
        return {
            restrict: 'A',
            link: function () {}
        }
    }]);

But when loading lazyloadModule, the debug log illustrates that ocLazyLoad loaded sharedDirective again.

ocLazyLoad.fileLoaded lazyload-module.js
angular.js:11500 ocLazyLoad.componentLoaded ["sharedModule", "directive", "sharedDirective"]
angular.js:11500 ocLazyLoad.moduleReloaded sharedModule
angular.js:11500 ocLazyLoad.moduleLoaded lazyloadModule

The confusing part is if i put sharedDirective in a sub module which required by sharedModule like this:

angular.module('sharedModule', ['sharedModuleSub']);
angular.module('sharedModuleSub', [])
    .directive('sharedDirective', [function () {
        return {
            restrict: 'A',
            link: function () {}
        }
    }]);

Then everything works fine.

The behavior described in this issue will only happen if the application is launched by angular.bootstrap

[ocombe]

When it says "moduleReloaded" it's just that it finds "sharedModule" listed as a dependence and it checks if anything new needs to be triggered (for example if you put the option "rerun" it will trigger the run block again, or if you loaded new components in the module it will register them), but it doesn't declare anything new that is not needed, so don't worry about that.
You can test by adding a run block to "sharedModule", you'll see that it is only triggered the first time (when the app is bootstrapped) and not the second time when you lazy load the other module (unless you use rerun: true).

[merlinchen]

But it reloads the sharedDirective again which causes angular to throw

Multiple directives [sharedDirective, sharedDirective] asking for template on....

Sorry for the poor english that may misleads you :)

[merlinchen]

Here is a more complete plunker that illustrates my problem.

First click the "load lazyloadModule" to load the lazyloadModule module, then click "compile sharedDirective" to manually compile and append sharedDirective to dom. Then angular will thorw

Error: [$compile:multidir] Multiple directives [sharedDirective, sharedDirective] asking for template on: <shared-directive>

[ocombe]

Oh that's a bug that should be fixed :-/
Thanks for the report, I'll fix it.

[merlinchen]

Thanks for the fast response and your great work :)

[ocombe]

No problem, it's cool when someone takes the time to make a plunkr that I can use to reproduce the bug !

[ocombe]

It's in 0.5.2, thanks for your help I fixed 3 bugs in one, and now you don't need to use loadedModules when you use angular.bootstrap, it just works :)

[merlinchen]

bravo!