Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Url with hash fails to lazyload #153

Closed
websirnik opened this issue Mar 23, 2015 · 2 comments
Closed

Url with hash fails to lazyload #153

websirnik opened this issue Mar 23, 2015 · 2 comments
Labels
bug
Milestone
1.0 - Stable api ...

Comments

@websirnik
Copy link
Contributor

AddThis uses url with the hash to pass account ID to the javascript.

screen_shot_2015-03-23_at_14_20_12_1

When I'm lazy-loading - //s7.addthis.com/js/300/addthis_widget.js#pubid=MYID&domready=1 - there is no request being sent and ocLazyLoad promise returns success, even though nothing has loaded.

It used to work with 0.5.2. But not with the recent 0.6.3 and 1.0.0-alpha.
@ocombe ocombe added the bug label Mar 23, 2015
@ocombe ocombe added this to the 1.0 - Stable api & modularity milestone Mar 23, 2015
@ocombe
Copy link
Owner

ocombe commented Mar 23, 2015

Oh yes, I know where it comes from, sorry about that, I'll fix it tonight :)

@ocombe ocombe closed this as completed in 9e1d089 Mar 23, 2015
@ocombe
Copy link
Owner

ocombe commented Mar 23, 2015

Fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.0 - Stable api & modularity
Development

No branches or pull requests
2 participants
@ocombe @websirnik