fix(user-agent): guard against null-refs when parsing Safari user-agents #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Damn user agent tests, that's why I didn't want to include this test in the first place, but there was no easy other way to "fix" this bug :( |
|
Sounds good! FWIW - I've found this guy to be kinda handy for sanitizing those necessary evil agent-strings: https://github.com/faisalman/ua-parser-js . Not sure if it's worth the trouble or not given the use case. 12k minified is still 12k minified. |
ocombe
added a commit
that referenced
this pull request
May 29, 2015
fix: guard against null-refs when parsing Safari user-agents
|
All is working fine, thanks :) |
|
great! would it be possible to get a new minor version build / bump published today? |
|
Yes, I'm fixing a few more bugs and I'll release it |
|
👍 and thanks for this great module! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the specific problematic user-agent that we ran into was googlebot's:
AdsBot-Google-Mobile (+http://www.google.com/mobile/adsbot.html) Mozilla (iPhone; U; CPU iPhone OS 3 0 like Mac OS X) AppleWebKit (KHTML, like Gecko) Mobile SafariI removed the blacklisting of Chrome and PhantomJS from the conditional as neither have "version" anywhere in their agents, and the more generalized fix should catch them fine.
Didn't produce dist assets, but can do so if needed. Likewise, let me know if you want any tweaks to the implementation.